feat: enable hypercore in frontend #1857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerhard Steenkamp <[email protected]>
Signed-off-by: Gerhard Steenkamp <[email protected]>
Signed-off-by: Gerhard Steenkamp <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Gerhard Steenkamp <[email protected]>
Signed-off-by: Gerhard Steenkamp <[email protected]>
Signed-off-by: Gerhard Steenkamp <[email protected]>
Signed-off-by: Gerhard Steenkamp <[email protected]>
Signed-off-by: Gerhard Steenkamp <[email protected]>
dohaki
requested review from
amateima,
ashwinrava,
dohaki,
james-a-morris,
melisaguevara,
mrice32,
nicholaspai and
pxrl
as code owners
| const fillTxReceipt = await provider.getTransactionReceipt(data.fillTx); | ||
| const fillTxBlock = await provider.getBlock(fillTxReceipt.blockNumber); | ||
|
|
||
| const parsedFIllLog = parseFilledRelayLog(fillTxReceipt.logs); |
There was a problem hiding this comment.
Should be parsedFillLog not parsedFIllLog
| if (indirectDestinationRoutes.length === 0) { | ||
| if (!indirectDestinationRoute) { | ||
| throw new InvalidParamError({ | ||
| message: "No indirect bridge routes found to specified destination chain", |
There was a problem hiding this comment.
Suggested change
| message: "No indirect bridge routes found to specified destination chain", | |
| message: "No indirect bridge route found to specified destination chain", |
| if (indirectDestinationRoutes.length === 0) { | ||
| if (!indirectDestinationRoute) { | ||
| throw new InvalidParamError({ | ||
| message: "No indirect bridge routes found to specified destination chain", |
There was a problem hiding this comment.
Suggested change
| message: "No indirect bridge routes found to specified destination chain", | |
| message: "No indirect bridge route found to specified destination chain", |
| intermediaryOutputToken: { | ||
| symbol: intermediaryOutputToken.symbol, | ||
| decimals: intermediaryOutputToken.decimals, | ||
| address: intermediaryOutputToken.addresses[intermediaryChainId], |
There was a problem hiding this comment.
The return type before the change was IndirectDestinationRoute[] and now it is IndirectDestinationRoute, what's the reason for the change of fields in the return type here?
| externalProjectId?: string; | ||
| }[]; | ||
| intermediaryChains?: number[]; | ||
| outputTokens?: ( |
There was a problem hiding this comment.
What's the reason behind excluding the input and output token of the route here?
|
|
||
| export default { | ||
| name: "Hyperliquid", | ||
| fullName: "Hyperliquid", |
There was a problem hiding this comment.
What is the difference between name and fullName?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ACX-4459